In the Linux kernel, the following vulnerability has been resolved: spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks The ->runtime_suspend() and ->runtime_resume() callbacks are not expected to call spi_controller_suspend() and spi_controller_resume(). Remove calls to those in the cadence-qspi driver. Those helpers have two roles currently: - They stop/start the queue, including dealing with the kworker. - They toggle the SPI controller SPI_CONTROLLER_SUSPENDED flag. It requires acquiring ctlr->bus_lock_mutex. Step one is irrelevant because cadence-qspi is not queued. Step two however has two implications: - A deadlock occurs, because ->runtime_resume() is called in a context where the lock is already taken (in the ->exec_op() callback, where the usage count is incremented). - It would disallow all operations once the device is auto-suspended. Here is a brief call tree highlighting the mutex deadlock: spi_mem_exec_op() ... spi_mem_access_start() mutex_lock(&ctlr->bus_lock_mutex) cqspi_exec_mem_op() pm_runtime_resume_and_get() cqspi_resume() spi_controller_resume() mutex_lock(&ctlr->bus_lock_mutex) ... spi_mem_access_end() mutex_unlock(&ctlr->bus_lock_mutex) ...
History

Thu, 19 Sep 2024 10:45:00 +0000

Type Values Removed Values Added
Weaknesses CWE-416

cve-icon MITRE

Status: PUBLISHED

Assigner: Linux

Published: 2024-04-04T08:20:33.512Z

Updated: 2024-11-05T09:16:10.465Z

Reserved: 2024-02-19T14:20:24.179Z

Link: CVE-2024-26806

cve-icon Vulnrichment

Updated: 2024-08-02T00:14:13.643Z

cve-icon NVD

Status : Awaiting Analysis

Published: 2024-04-04T09:15:09.333

Modified: 2024-04-04T12:48:22.650

Link: CVE-2024-26806

cve-icon Redhat

Severity : Moderate

Publid Date: 2024-04-04T00:00:00Z

Links: CVE-2024-26806 - Bugzilla